Final PR raised #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
archanaatr
reviewed
Jun 14, 2022
| "name": "continue", | ||
| "value": "Continue" | ||
| } | ||
| ] |
There was a problem hiding this comment.
delete unused resources like country_flag_ad, flags.png etc
archanaatr
reviewed
Jun 14, 2022
| Column() { | ||
| Text('+' + String(this.phone_code)).fontSize("20fp") | ||
| .textOverflow({ overflow: TextOverflow.Ellipsis }) | ||
| .margin({left: 7,top: 3}) |
There was a problem hiding this comment.
Try to align text in the center instead of providing margin
archanaatr
reviewed
Jun 14, 2022
| ListItem() { | ||
| Row() { | ||
|
|
||
|
|
archanaatr
reviewed
Jun 14, 2022
| Text(item.co) | ||
| .width('30%') | ||
| .height("50vp") | ||
| .padding({left: 30}) |
archanaatr
reviewed
Jun 14, 2022
|
|
||
| PhoneCodePanel({ | ||
| show: this.show, | ||
| onPanelItemSelection: (phoneCode, countryCode) => { |
There was a problem hiding this comment.
Hide phone code panel by dragging it down, then click on arrow of phonecode may not bring up the panel as show value is not updated in this scenario. Please check and handle this scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.