thread configuration (names & QoS on Darwin) #2943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-thread-config
branch
from
f5b6b19
to
82af47f
Compare
weissi
force-pushed
the
jw-thread-config
branch
from
82af47f
to
aa82870
Compare
Lukasa
pushed a commit
that referenced
this pull request
Oct 23, 2024
### Motivation: On Darwin, QoS (quality of service) of threads plays an important role, especially on Apple Silicon machines with P-cores and E-cores. If you spawn raw threads (like NIOPosix) and use a mechanism that doesn't support QoS propagation (like reading/writing to networks -- like NIOPosix does), it's recommended to default to the main thread's QoS. Otherwise you'll always be at the default QoS for "legacy" threads which means bad latencies, especially on Apple Silicon machines. In a follow-up PR #2943 we're adding better configurability for thread configuration. ### Modifications: Default to main thread QoS on Darwin. ### Result: Better latencies for applications with higher QoS classes.
glbrntt
reviewed
Nov 6, 2024
| @@ -70,7 +70,7 @@ public final class MultiThreadedEventLoopGroup: EventLoopGroup { | |||
| private let index = ManagedAtomic<Int>(0) | |||
| private var eventLoops: [SelectableEventLoop] | |||
| private let shutdownLock: NIOLock = NIOLock() | |||
| private let threadNamePrefix: String | |||
| private let threadNamePrefix: String? | |||
| @@ -108,7 +108,8 @@ public final class MultiThreadedEventLoopGroup: EventLoopGroup { | |||
| } | |||
|
|
|||
| private static func setupThreadAndEventLoop( | |||
| name: String, | |||
| name: String?, | |||
There was a problem hiding this comment.
How come name is optional now?
| #endif | ||
|
|
||
| public struct NIOThreadConfiguration: Sendable { | ||
| public var threadNamePrefix: Optional<String> |
There was a problem hiding this comment.
Can you document how this is used and the recommendations for its value? I know from looking at some examples that "-" is necessary for the various groupings and also that the prefix should be reasonably short.
Can you document what nil means in this context too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For the longest time, NIO only had internal APIs to choose the thread names and on Darwin, there was no way to assign the NIO threads certain QoS classes. That meant that on Darwin (e.g. macOS) you would always get poor latencies with NIOPosix, particularly on Apple Silicon machines where NIO might sometimes be restricted to the E-cores.
Modifications:
NIOThreadConfigurationwhich lets you configure a thread name prefix & QoS on DarwinResult: