improvement: pass down file/line in makeFutureWithTask #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
May 1, 2024
There was a problem hiding this comment.
Thanks for this! This is a good change, however we can't accept it as-is because it's API breaking. We need to keep the old function around, which also means we need a slight name change for the new one, along with a deprecation for the old one and a good fixit.
How about makeFutureWithResultOfTask?
In some circumstances it can be difficult to know which specific call to makeFutureWithTask leaked a promise. Adds a new function that passes down file/line to help aid debugging such situations.
Austinpayne
force-pushed
the
improvement/async-promise-tracing
branch
from
ea16fc3
to
25d29f5
Compare
|
@Lukasa Thanks, I forgot about that detail! |
|
Thanks, this looks a lot better! Can you update the tests? I think two changes are needed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances it can be difficult to know which specific call to
makeFutureWithTaskleaked a promise. Passes through file/line to help aid debugging such situations.