Fix incorrect or confusing documentation about Swift versions #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
reviewed
Nov 6, 2024
| @@ -29,14 +29,22 @@ struct CountLines: AsyncParsableCommand { | |||
|
|
|||
| ### Usage in Swift 5.5 | |||
There was a problem hiding this comment.
@natecook1000 what do you think about just dropping this content from the docs? Current ArgumentParser doesn't support 5.5 and users of a version that does can reference older documentation instead.
There was a problem hiding this comment.
@rauhul @natecook1000 What can I do to move this forward?
Thanks.
Rewrote Markdown to properly specify Swift 5.7 instead of 5.5, and to clarify other information related to Swift versions. Resolve apple#677 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
677-swift-version-documentation
branch
from
e7369ac
to
b63295d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect or confusing documentation about Swift versions
Rewrote Markdown to properly specify Swift 5.7 instead of 5.5, and to clarify other information related to Swift versions.
Resolve #677
Checklist