Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catalog migration w/o connection #30773

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: catalog migration w/o connection #30773

merged 1 commit into from
Nov 1, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Fix the catalog upgrade/downgrade when we can't connect to the analytics database during the migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Oct 31, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 31, 2024
@michael-s-molina michael-s-molina removed the risk:db-migration PRs that require a DB migration label Nov 1, 2024
@michael-s-molina michael-s-molina merged commit 402c29c into master Nov 1, 2024
37 of 38 checks passed
sadpandajoe pushed a commit that referenced this pull request Nov 1, 2024
@betodealmeida @sadpandajoe
fix: catalog migration w/o connection (#30773)
ad82a8c 
(cherry picked from commit 402c29c)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina michael-s-molina is a code owner

Assignees

@betodealmeida betodealmeida

Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
No open projects
Apache Superset 4.1
Status: Cherried
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@betodealmeida @eschutho @mistercrunch @sadpandajoe @michael-s-molina