[SPARK-46689][SPARK-46690][PYTHON][CONNECT] Support v2 profiling in group/cogroup applyInPandas/applyInArrow #45050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
reviewed
Feb 7, 2024
xinrong-meng
changed the title
xinrong-meng
force-pushed
the
other_p2
branch
from
306a427
to
877056b
Compare
ueshin
reviewed
Feb 8, 2024
| df1 = self.spark.createDataFrame([(1, 1.0), (2, 2.0), (1, 3.0), (2, 4.0)], ("id", "v1")) | ||
| df2 = self.spark.createDataFrame([(1, "x"), (2, "y")], ("id", "v2")) | ||
|
|
||
| def summarize(l, r): |
There was a problem hiding this comment.
Shall we rename to left and right according to the lint error?
There was a problem hiding this comment.
I was wondering the reason and saw "In some fonts, these characters are indistinguishable from the numerals one and zero. When tempted to use 'l', use 'L' instead." That's good to learn :p
| df1 = self.spark.createDataFrame([(1, 1.0), (2, 2.0), (1, 3.0), (2, 4.0)], ("id", "v1")) | ||
| df2 = self.spark.createDataFrame([(1, "x"), (2, "y")], ("id", "v2")) | ||
|
|
||
| def summarize(l, r): |
|
Merged to master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support v2 (perf, memory) profiling in group/cogroup applyInPandas/applyInArrow, which rely on physical plan nodes FlatMapGroupsInBatchExec and FlatMapCoGroupsInBatchExec.
Why are the changes needed?
Complete v2 profiling support.
Does this PR introduce any user-facing change?
Yes. V2 profiling in group/cogroup applyInPandas/applyInArrow is supported.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.