Update LabelValue obtain pod information function to add default value parameter
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, this means, select the first value of given keys, if all are null, fall into default value? |
|
Yes. |
|
I would suggest rename this to valueOfFirstNotNullLabel. default value is fine as a parameter. |
|
We already have the |
|
We don't support overload? |
|
Yes, I use a structure to implement the functions, and overload is not supported in the Golang structure. |
|
Then it is better to change the old function through add a new parameter. |
mrproliu
changed the title
LabelValueWithDefault function to obtain information from podLabelValue obtain pod information function to add default value parameter
wu-sheng
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.