Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the index mode failure on multi-segments #558

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Fix the index mode failure on multi-segments #558

merged 2 commits into from
Nov 16, 2024

Conversation

hanahmily
Copy link
Contributor

When there are more than one segment, the heap sorting will fail

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

@hanahmily
Init
3720cfb 
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily
fix the issues when mulit-segments is here
eb0189c 
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added the bug Something isn't working label Nov 16, 2024
@hanahmily hanahmily added this to the 0.8.0 milestone Nov 16, 2024
@wu-sheng wu-sheng merged commit 0794832 into main Nov 16, 2024
14 checks passed
@wu-sheng wu-sheng deleted the index branch November 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@lujiajing1126 lujiajing1126 Awaiting requested review from lujiajing1126

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

@wankai123 wankai123 Awaiting requested review from wankai123

@ButterBright ButterBright Awaiting requested review from ButterBright

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hanahmily @wu-sheng