Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support etcd client authentication #331

Merged
merged 13 commits into from
Oct 20, 2023

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Sep 16, 2023

Set authentication parameters from startup command

Fix apache/skywalking#9187

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Support set etcd authentication parameters from startup command

@hailin0 hailin0 added the enhancement New feature or request label Sep 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Merging #331 (a9acb9c) into main (81011a4) will decrease coverage by 0.01%.
The diff coverage is 36.58%.

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   39.32%   39.31%   -0.01%     
==========================================
  Files         112      112              
  Lines       12329    12370      +41     
==========================================
+ Hits         4848     4863      +15     
- Misses       7003     7029      +26     
  Partials      478      478              
Files Coverage Δ
banyand/metadata/client.go 47.23% <100.00%> (+2.72%) ⬆️
banyand/metadata/schema/etcd.go 47.57% <21.21%> (-3.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Set authentication parameters from startup command
@hailin0 hailin0 force-pushed the main-etcd-client-authentication branch from c486996 to 4ae829d Compare September 16, 2023 15:21
@wu-sheng wu-sheng added this to the 0.5.0 milestone Sep 16, 2023
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should create test cases to ensure the added items are verified. You can utilize "test/integration/distributed/setup/node_test.go" as a reference for writing the test cases.

banyand/metadata/client.go Outdated Show resolved Hide resolved
banyand/metadata/client.go Outdated Show resolved Hide resolved
banyand/metadata/client.go Outdated Show resolved Hide resolved
banyand/metadata/client.go Outdated Show resolved Hide resolved
@hanahmily hanahmily modified the milestones: 0.5.0, 0.6.0 Oct 17, 2023
@hailin0
Copy link
Member Author

hailin0 commented Oct 18, 2023

You should create test cases to ensure the added items are verified. You can utilize "test/integration/distributed/setup/node_test.go" as a reference for writing the test cases.

@hanahmily please help to review

.licenserc.yaml Outdated Show resolved Hide resolved
test/integration/etcd/client_test.go Outdated Show resolved Hide resolved
test/integration/etcd/client_test.go Show resolved Hide resolved
docs/installation/cluster.md Outdated Show resolved Hide resolved
docs/installation/cluster.md Outdated Show resolved Hide resolved
docs/installation/cluster.md Outdated Show resolved Hide resolved
docs/installation/cluster.md Outdated Show resolved Hide resolved
docs/installation/cluster.md Outdated Show resolved Hide resolved
docs/installation/cluster.md Show resolved Hide resolved
@hailin0
Copy link
Member Author

hailin0 commented Oct 20, 2023

@hanahmily PTAL

@hanahmily hanahmily merged commit d722db6 into apache:main Oct 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Enhance etcd auth configuration
4 participants