-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SINGA-270 Installation error: include/singa/proto/ is not in /usr/local/include #282
base: master
Are you sure you want to change the base?
Conversation
…al/include Fix the installation path of include/singa/proto.
I tried the PR. The directory /usr/local/include/singa/proto/ exists now, but there is a compile error when I try to compile test.cpp from #272 : $ g++ ./test.cpp -l singa |
…al/include Fix dependent lib installation. Add a new option to disable glog usage.
The problem is caused by using two different protobuf libs. |
Ok. I think the problem is fixed now and the PR can be merged. Thank you. |
@@ -49,6 +49,7 @@ OPTION(USE_CUDA "Use Cuda libs" OFF) | |||
OPTION(USE_CUDNN "Use Cudnn libs" ON) | |||
OPTION(USE_OPENCV "Use opencv" OFF) | |||
OPTION(USE_LMDB "Use LMDB libs" OFF) | |||
OPTION(USE_GLOG "Use glog libs" ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this one?
I think we agreed to remove it and use it if cmake can detect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If cmake detects glog, then we link glog statically into libsinga.so.
In this way, we would not have the linking error when compiling user code.
Fix the installation path of include/singa/proto.