Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated KEYS file from repository #683

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 8, 2024

Change

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested a review from rzo1 November 8, 2024 06:22
@mawiesne mawiesne self-assigned this Nov 8, 2024
@rzo1 rzo1 merged commit 637fd35 into main Nov 8, 2024
14 checks passed
@rzo1 rzo1 deleted the remove-outdated-KEYS-file-from-repo branch November 8, 2024 06:23
@jzonthemtn
Copy link
Contributor

Is the KEYS file moved somewhere else?

@rzo1
Copy link
Contributor

rzo1 commented Nov 8, 2024

@jzonthemtn the location for the KEYS file is the distribution area of OpenNLP which is here https://dist.apache.org/repos/dist/release/opennlp/KEYS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants