Improved: Improve ViewHandler interface (OFBIZ-13179) #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmalin
force-pushed
the
ViewMapImprovement
branch
4 times, most recently
from
03264d5
to
4429a34
Compare
We extend *AbstractViewHandler* with a new method to override *prepareViewContext*. For each view handler implementation this will allow to control context used for rendering, applying Scriptlet token detection for security purpose. A new class *SecuredFreemarker* has been created to manage freemarker specific controls, outside global *SecurityUtil* class. We also add a new parameter *secure-context* (set true by default) to view-map xml element to indicate that this view allow unsecure rendering, this implies the view-map to required authentication. Thanks to Gil Portenseigne for help
nmalin
force-pushed
the
ViewMapImprovement
branch
from
4429a34
to
8576da3
Compare
|
nmalin
added a commit
that referenced
this pull request
Nov 28, 2024
We extend *AbstractViewHandler* with a new method to override *prepareViewContext*. For each view handler implementation this will allow to control context used for rendering, applying Scriptlet token detection for security purpose. A new class *SecuredFreemarker* has been created to manage freemarker specific controls, outside global *SecurityUtil* class. We also add a new parameter *secure-context* (set true by default) to view-map xml element to indicate that this view allow unsecure rendering, this implies the view-map to required authentication. Thanks to Gil Portenseigne for help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend AbstractViewHandler with a new method to override prepareViewContext. For each view handler implementation this will allow to control context used for rendering, applying Scriptlet token detection for security purpose.
A new class SecuredFreemarker has been created to manage freemarker specific controls, outside global SecurityUtil class.
We also add a new parameter secure-context (set true by default) to view-map xml element to indicate that this view allow unsecure rendering, this implies the view-map to required authentication.
Thanks to Gil Portenseigne for help