Improved: Ensure unique email when sendEmail OFBIZ-13170 #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you run the service sendCommEventAsEmail if commEvent to send contains multiple party with the same email (through different contactMech), email will be sent to many times to the same box (depending on the smtp configuration). To avoid this case, we will ensure that an email is unique for the sender list.
|
Did not test (not easy) but after simple review sounds good to me because of the use of |
gtchaboussie
reviewed
Nov 8, 2024
| String sendCc = null; | ||
| String sendBcc = null; | ||
| // add other parties from roles, collect all email on map to parse it after | ||
| List<String> emailAlreadyLoad = UtilMisc.toList(sendTo); |
There was a problem hiding this comment.
alreadyLoaded instead of alreadyLoad ?
change name emailAlreadyLoad by alreadyLoaded
|
|
Thanks both for remarks |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run the service sendCommEventAsEmail if commEvent to send contains multiple party with the same email (through different contactMech), email will be sent to many times to the same box (depending on the smtp configuration).
To avoid this case, we will ensure that an email is unique for the sender list.