Improved: findParty_Status. (OFBIZ-12677) #531
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| <attribute name="noConditionFind" type="String" mode="IN" optional="true" default-value="N"/> | ||
| <attribute name="extInfo" type="String" mode="IN" optional="true"/> | ||
| <attribute name="extCond" type="org.apache.ofbiz.entity.condition.EntityCondition" mode="IN" optional="true"> | ||
| <description>EntityCondition that can be send to this service to manage complex search case</description> | ||
| </attribute> | ||
| <attribute name="partyId" type="String" mode="IN" optional="true"/> <!-- does a LIKE compare on this, can do partial, case insensitive, etc --> | ||
| <attribute name="partyTypeId" type="String" mode="IN" optional="true"/> | ||
| <attribute name="roleTypeId" type="String" mode="IN" optional="true"/> |
There was a problem hiding this comment.
I think this is unwanted change. Could you please revert?
There was a problem hiding this comment.
I agree I see no reason why
<attribute name="roleTypeId" type="String" mode="IN" optional="true"/> <!-- can be null or ANY to include any -->
has been moved. Not a big deal but we lose the comment
| // NOTE: _must_ explicitly allow null as it is not included in a not equal in many databases... odd but true | ||
| andExprs.add(EntityCondition.makeCondition(EntityCondition.makeCondition("statusId", GenericEntity.NULL_FIELD), | ||
| EntityOperator.OR, EntityCondition.makeCondition("statusId", EntityOperator.NOT_EQUAL, "PARTY_DISABLED"))); | ||
| if ("PARTY_ENABLED".equals(statusId)) { |
There was a problem hiding this comment.
Could you please share use case why this change is needed?
There was a problem hiding this comment.
I think it's OK to be able to select disabled party. That can make sense in some situations.
There was a problem hiding this comment.
We'll discuss those changes and will provide an altered pull request.
Will take at least two weeks as georg is not available atm.
|
Hi @mbrohl, should we close? |
|
I'll check when I'm back from vacation. |
Improved: Backend Party Manager: Removed hidden statusId field and added drop-down for status selection in findparty form to be able to find not ENABLED parties too. (OFBIZ-12677)
Central actor search around the static Party.statusId field simplified and the logic behind it fixed. Thus, the statusId value is also available in performPartyFind Service.