Skip to content

Commit

Permalink
Improved: Use auto-attribute element instead list all attributes for …
Browse files Browse the repository at this point in the history
…getPartyPostalAddress

Simple improvement to replace all OUT attribute for the getPartyPostalAddress service definition by auto-attributes on entity PostalAddress who contains all.
  • Loading branch information
nmalin committed Oct 4, 2024
1 parent 269e3f2 commit ad84551
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions applications/party/servicedef/services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1114,21 +1114,14 @@ under the License.
<service name="getPartyPostalAddress" engine="groovy"
location="component://party/src/main/groovy/org/apache/ofbiz/party/party/PartyServicesScript.groovy" invoke="getPartyPostalAddress" auth="false">
<description>Get the party postal address</description>
<auto-attributes entity-name="PostalAddress" mode="OUT" optional="true"/>
<attribute name="partyId" type="String" mode="IN" optional="false">
<type-validate>
<fail-property resource="PartyErrorUiLabels" property="PartyRequiredFieldMissingPartyId"/>
</type-validate>
</attribute>
<attribute name="contactMechPurposeTypeId" type="String" mode="INOUT" optional="true"/>
<attribute name="contactMechId" type="String" mode="OUT" optional="true"/>
<attribute name="address1" type="String" mode="OUT" optional="true"/>
<attribute name="address2" type="String" mode="OUT" optional="true"/>
<attribute name="directions" type="String" mode="OUT" optional="true"/>
<attribute name="city" type="String" mode="OUT" optional="true"/>
<attribute name="postalCode" type="String" mode="OUT" optional="true"/>
<attribute name="stateProvinceGeoId" type="String" mode="OUT" optional="true"/>
<attribute name="countyGeoId" type="String" mode="OUT" optional="true"/>
<attribute name="countryGeoId" type="String" mode="OUT" optional="true"/>
</service>

<service name="createPartyCarrierAccount" default-entity-name="PartyCarrierAccount" engine="entity-auto" invoke="create" auth="true">
Expand Down

0 comments on commit ad84551

Please sign in to comment.