Skip to content

Commit

Permalink
Improved: Fix some bugs SpotBugs reports (OFBIZ-12386)
Browse files Browse the repository at this point in the history
  After https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33fc03fa10

  I thought the problem was fixed since it's excluded. But it was not because
  there was a typo (a trailing blank in
  <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR " />)

  So I fixed that, but to my surprise it still does not work, weird :/

Completes previous commit. The reason was that the whole class was concerned.
  • Loading branch information
JacquesLeRoux committed Oct 29, 2024
1 parent 97aee6d commit 53cbb74
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions spotbugs/exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,8 @@ under the License.
<Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS" />
</Match><!-- ^ ^ not a problem, false positives -->
<Match>
<!-- As it's also used by WebAppCacheTest class I made it package. That's safer but not enough as private so it's here -->
<!-- As it's also used by WebAppCacheTest class I made it package. That's safer but not enough as private so it's here with the whole class-->
<Class name="org.apache.ofbiz.webapp.WebAppCache" />
<Method name="WebAppCache" />
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
</Match>
</FindBugsFilter>

0 comments on commit 53cbb74

Please sign in to comment.