drivers/serial/serial.c: adapt to the iovec-based api #14898
+348
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Drivers
|
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing, it lacks crucial details. Here's a breakdown of missing information:
Specifically, the author needs to:
|
yamt
force-pushed
the
readv-serial
branch
2 times, most recently
from
97c844f
to
786ab3b
Compare
This can simplify partial result handling.
"total" is a bit confusing after the introduction of uio_advance().
although i'm not quite happy with the "offset" functionality, it's necessary to simplify the adaptation of some drivers like drivers/serial/serial.c, which (ab)uses the user-supplied buffer as a line-buffer.
This would fix readv/writev issues mentioned in apache#12674. (only for this specific driver though. with this approach, we basically have to fix every single drivers and filesystems.) Lightly tested on the serial console, using micropython REPL on toywasm with esp32s3-devkit:toywasm, which used to be suffered by the readv issue.
| @@ -45,6 +45,7 @@ struct uio | |||
| { | |||
| FAR const struct iovec *uio_iov; | |||
| int uio_iovcnt; | |||
| size_t uio_offset_in_iov; /* offset in uio_iov[0].iov_base */ | |||
| @@ -102,6 +101,11 @@ static ssize_t file_readv_compat(FAR struct file *filep, | |||
| remaining -= nread; | |||
| } | |||
|
|
|||
| if (ntotal >= 0) | |||
| { | |||
| uio_advance(uio, ntotal); | |||
There was a problem hiding this comment.
what's benefit to update the offset in one of uio entry
| * Or -EOVERFLOW. | ||
| * | ||
| ****************************************************************************/ | ||
|
|
||
| ssize_t uio_total_len(FAR const struct uio *uio) | ||
| ssize_t uio_resid(FAR const struct uio *uio) |
| } | ||
|
|
||
| sz -= iov->iov_len; | ||
| iov++; |
There was a problem hiding this comment.
should we set iov->iov_offset_in_iov to iov->iov_len
| { | ||
| return -EOVERFLOW; | ||
| } | ||
|
|
||
| len += iov[i].iov_len; | ||
| len += iov[i].iov_len - offset_in_iov; | ||
| offset_in_iov = 0; |
There was a problem hiding this comment.
should we set ti iov[i].iov_offset_in_iov
| * | ||
| ****************************************************************************/ | ||
|
|
||
| void uio_copyto(FAR struct uio *uio, size_t offset, FAR void *buf, |
There was a problem hiding this comment.
how to support call uio_copyto/from mulitple time with the same uio and the partial buffer
| @@ -84,6 +84,7 @@ void uio_advance(FAR struct uio *uio, size_t sz) | |||
| int iovcnt = uio->uio_iovcnt; | |||
| size_t offset_in_iov = uio->uio_offset_in_iov; | |||
|
|
|||
| DEBUGASSERT(sz <= uio_resid(uio)); | |||
There was a problem hiding this comment.
merge tl the patch which add uio_advance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drivers/serial/serial.c: adapt to the iovec-based api
This would fix readv/writev issues mentioned in
#12674.
(only for this specific driver though. with this approach,
we basically have to fix every single drivers and
filesystems.)
Impact
Testing
Lightly tested on the serial console, using micropython REPL
on toywasm with esp32s3-devkit:toywasm, which used to be
suffered by the readv issue.