Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/adb: Fix log format error #2862

Conversation

JianyuWang0623
Copy link
Contributor

@JianyuWang0623 JianyuWang0623 commented Nov 21, 2024

Summary

The "%pV" format depends on libc extension
e.g. Calling avb_log() in function adbd_main():

  adbd_main (***): 0x3fc9175cV

Impact

system/adb

Testing

  • Selftest - esp32s3-devkit:adb (the config has not been upstreamed)
  • NuttX CI

The "%pV" format depends on libc extension

Log

  adbd_main (***): 0x3fc9175cV

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@cederom
Copy link

cederom commented Nov 21, 2024

Thank you @JianyuWang0623 :-) Please let us know when testing is finished and successful :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 70e7ad8 into apache:master Nov 22, 2024
25 checks passed
@JianyuWang0623
Copy link
Contributor Author

Thank you @JianyuWang0623 :-) Please let us know when testing is finished and successful :-)

Sorry, selftest here is already passed.
I mean the config esp32s3-devkit:adb has not been upstreamed(in processing).

@cederom
Copy link

cederom commented Nov 22, 2024

Very cool! Thank you for the fix! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants