-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake(build):add missing basic and nxlooper cmake script #2857
Conversation
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it addresses some aspects, it lacks crucial details. Here's a breakdown of what's missing and how to improve it: Missing Information in Summary:
Missing Information in Impact:
Missing Information in Testing:
Example of an Improved PR Description: ## Summary
This PR addresses a missing CMake build configuration for the interpreter and nxlooper components, which was causing CI failures (https://github.com/apache/nuttx/actions/runs/11880169863/job/33103008538?pr=14756). Previously, these components were not included in the standard NuttX build process for the `sim:minibasic` and `sim:alsa` configurations. This change adds the necessary CMake build rules to include the interpreter and nxlooper source files and dependencies in the respective `CMakeLists.txt` files.
## Impact
* **New feature added?** YES (if the interpreter wasn't previously available), or NO (if it existed but couldn't be built). Be explicit.
* **Impact on user:** YES (if new feature) Users can now build and use the interpreter on simulated `minibasic` and `alsa` configurations. NO (if just build fix) No user-facing changes other than a fixed build.
* **Impact on build:** YES. The interpreter and nxlooper are now included in the build for `sim:minibasic` and `sim:alsa` configurations.
* **Impact on hardware:** NO.
* **Impact on documentation:** YES (if new feature). Documentation should be updated to describe how to use the new interpreter functionality. NO (if just build fix) Assuming no functional changes.
* **Impact on security:** NO.
* **Impact on compatibility:** NO.
* **Anything else to consider?** None.
## Testing
I confirm that changes are verified on my local setup and work as intended:
* **Build Host:** Linux (Ubuntu 22.04), x86_64, GCC 11.2.0
* **Target(s):** `sim:qemu-x86_64:minibasic`, `sim:qemu-x86_64:alsa`
Testing logs before change:
[ERROR] CMake Error at .../CMakeLists.txt: (some error message indicating missing interpreter/nxlooper build)
Build completed successfully.
By providing more comprehensive information, reviewers can more easily understand the purpose, impact, and validation of your changes, leading to a faster and smoother review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xuxin930 :-)
Summary
add interpreter basic and nxlooper missing CMake build
Impact
fix ci fail in https://github.com/apache/nuttx/actions/runs/11880169863/job/33103008538?pr=14756
Testing
refresh pass