Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mahout-1958] Change the variable type to long to avoid overflow #444

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

balashashanka
Copy link
Contributor

@balashashanka balashashanka commented Apr 19, 2024

Purpose of PR:

Please give a short description of what this PR is for.

Important ToDos

Please mark each with an "x"

  • A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
  • Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
  • Created unit tests where appropriate
  • Added licenses correct on newly added files
  • Assigned JIRA to self
  • Added documentation in scala docs/java docs, and to website
  • Successfully built and ran all unit tests, verified that all tests pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should be made?

@balashashanka balashashanka changed the base branch from main to trunk April 19, 2024 15:21
@rawkintrevo
Copy link
Contributor

Thanks for the contrib @balashashanka

Successfully built and ran all unit tests, verified that all tests pass locally.

Did mvn clean install build without failures?

@andrewmusselman
Copy link
Contributor

We can merge if this is looking good @balashashanka , did it build for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants