Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: use Java 17 as the build target, require Java 17+ for execution #6220

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Jan 5, 2024

Description

Bump baseline to Java 17

@vlsi
Copy link
Collaborator Author

vlsi commented Jan 5, 2024

com.github.autostyle.FormatterException: Error while formatting src/functions/src/main/java/org/apache/jmeter/functions/ChangeCase.java: 87:29: error: illegal start of expression
                Caused by: com.google.googlejavaformat.java.FormatterException: 87:29: error: illegal start of expression
                    at com.google.googlejavaformat.java.FormatterException.fromJavacDiagnostics(FormatterException.java:50)
                    at com.google.googlejavaformat.java.RemoveUnusedImports.parse(RemoveUnusedImports.java:253)
                    at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports(RemoveUnusedImports.java:211)
                    at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports(RemoveUnusedImports.java:204)
                    at com.github.autostyle.java.GoogleJavaFormatStep$State.lambda$createRemoveUnusedImportsOnly$1(GoogleJavaFormatStep.java:156)
                    at com.github.autostyle.FormatterFunc.apply(FormatterFunc.java:31)
                    at com.github.autostyle.FormatterStepImpl$Standard.format(FormatterStepImpl.java:77)
                    at com.github.autostyle.FormatterStep$Strict.format(FormatterStep.java:76)
                    at com.github.autostyle.Formatter.compute(Formatter.java:204)
                    at com.github.autostyle.Formatter.formatOrNull(Formatter.java:171)

Need to bump google java format so it parses Java text blocks properly.

@vlsi
Copy link
Collaborator Author

vlsi commented Jan 9, 2024

The solution for RemoveUnusedImports would be using https://docs.openrewrite.org/recipes/java/removeunusedimports via #6217

@vlsi vlsi force-pushed the java17 branch 2 times, most recently from 88429d7 to 63746b4 Compare January 9, 2024 08:06
@vlsi vlsi added this to the 6.0 milestone Jan 9, 2024
@vlsi vlsi force-pushed the java17 branch 3 times, most recently from f4e0bc0 to cfc2297 Compare January 9, 2024 08:40
@vlsi vlsi changed the title chore: set Java target to 17 change: use Java 17 as the build target, require Java 17+ for execution Jan 9, 2024
@vlsi vlsi merged commit 09c3f81 into apache:master Jan 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant