Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of utilities bundled jar #538

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Reduce size of utilities bundled jar #538

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d11406a
excluded unused dependencies from spark jars
Sep 17, 2024
1c80e84
make lombok dependency scope provided
Sep 17, 2024
2bb64d5
remove servlet dependencies
Sep 17, 2024
2e1f7d0
removed unused dependencies
Sep 17, 2024
33e32b4
removed non-compaint dependencies
Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
</dependencies>

Expand Down Expand Up @@ -173,7 +174,7 @@
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.24</version>
<scope>compile</scope>
<scope>provided</scope>
</dependency>
the-other-tim-brown marked this conversation as resolved.
Show resolved Hide resolved

<!-- Hudi -->
Expand Down
66 changes: 19 additions & 47 deletions xtable-utilities/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,24 @@
<dependency>
<groupId>org.apache.xtable</groupId>
<artifactId>xtable-core</artifactId>
<exclusions>
<exclusion>
<groupId>javax.servlet</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>javax.servlet.jsp</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.eclipse.jetty</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.antlr</groupId>
<artifactId>antlr4-runtime</artifactId>
</exclusion>
</exclusions>
Comment on lines +75 to +76
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding servlet and antlr-runtime dependencies, since they're not being used in utilities.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which dependency are these servlet and antlr coming from ? These are not Apache 2.0 compliant actually. Can you check if the ones marked in yellow for xtable-utilities can be removed ?

https://docs.google.com/spreadsheets/d/1XBCZBeWqF2D5d1L4H9fRQ1QLarJq4tLgIEgnGiNdoV8/edit?usp=sharing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

servlet jars are coming from multiple dependencies like hudi-common, and hbase-server as shown below. Antlr is coming from delta-core

[INFO] +- org.apache.xtable:xtable-core:jar:0.2.0-SNAPSHOT:compile
[INFO] | +- org.apache.hudi:hudi-java-client:jar:0.14.0:compile
[INFO] | | - org.apache.hudi:hudi-client-common:jar:0.14.0:compile
[INFO] | | +- org.apache.hudi:hudi-timeline-service:jar:0.14.0:compile
[INFO] | | | +- io.javalin:javalin:jar:4.6.7:compile
[INFO] | | | | +- org.eclipse.jetty:jetty-server:jar:9.4.54.v20240208:compile
[INFO] | | | | | +- org.eclipse.jetty:jetty-http:jar:9.4.54.v20240208:compile
[INFO] | | | | | - org.eclipse.jetty:jetty-io:jar:9.4.54.v20240208:compile
[INFO] | | | | +- org.eclipse.jetty:jetty-webapp:jar:9.4.54.v20240208:compile
[INFO] | | | | | +- org.eclipse.jetty:jetty-xml:jar:9.4.54.v20240208:compile
[INFO] | | | | | - org.eclipse.jetty:jetty-servlet:jar:9.4.54.v20240208:compile
[INFO] | | | | | - org.eclipse.jetty:jetty-security:jar:9.4.54.v20240208:compile
[INFO] | | | | +- org.eclipse.jetty.websocket:websocket-server:jar:9.4.54.v20240208:compile
[INFO] | | | | | +- org.eclipse.jetty.websocket:websocket-common:jar:9.4.54.v20240208:compile
[INFO] | | | | | | - org.eclipse.jetty.websocket:websocket-api:jar:9.4.54.v20240208:compile
[INFO] | | | | | +- org.eclipse.jetty.websocket:websocket-client:jar:9.4.54.v20240208:compile
[INFO] | | | | | | - org.eclipse.jetty:jetty-client:jar:9.4.54.v20240208:compile
[INFO] | | | | | - org.eclipse.jetty.websocket:websocket-servlet:jar:9.4.54.v20240208:compile

] +- org.apache.xtable:xtable-core:jar:0.2.0-SNAPSHOT:compile
[INFO] | +- com.fasterxml.jackson.module:jackson-module-scala_2.12:jar:2.17.1:compile
[INFO] | +- org.apache.hudi:hudi-common:jar:0.14.0:compile
[INFO] | | +- org.apache.hbase:hbase-server:jar:2.4.9:compile
[INFO] | | | +- javax.servlet.jsp:javax.servlet.jsp-api:jar:2.3.1:compile

[INFO] +- org.apache.xtable:xtable-core:jar:0.2.0-SNAPSHOT:compile
[INFO] | +- org.apache.xtable:xtable-hudi-support-utils:jar:0.2.0-SNAPSHOT:compile
[INFO] | - io.delta:delta-core_2.12:jar:2.4.0:compile
[INFO] | +- io.delta:delta-storage:jar:2.4.0:compile
[INFO] | - org.antlr:antlr4-runtime:jar:4.9.3:compile

Copy link
Author

@vamsikarnika vamsikarnika Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see below dependencies are present in the current dependency tree for utilties module that are marked yellow in the sheet. Will try to remove them

jersey-json
jersey-core
jersey-server
jersey-servlet
jaxb-impl
javax.activation-api
javax.annotation-api
javax.servlet.jsp-api
javax.servlet-api
javax.ws.rs-api
jsr311-api
jaxb-api
javax.servlet.jsp
javax.el
jol-core

Copy link
Author

@vamsikarnika vamsikarnika Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xtable sync is failing on removing below non-complainr dependencies

jersey-server
jol-core

</dependency>

<!-- command line arg parsing -->
Expand All @@ -62,26 +80,6 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
</dependency>

<!-- Spark -->
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_${scala.version.prefix}</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.version.prefix}</artifactId>
<scope>runtime</scope>
</dependency>
Copy link
Author

@vamsikarnika vamsikarnika Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing these dependencies after running mvn dependency:analyze is returning these jars are unused dependencies in the utilities module.

[WARNING] Unused declared dependencies found:
[WARNING] org.apache.logging.log4j:log4j-core:jar:2.22.0:compile
[WARNING] org.apache.logging.log4j:log4j-slf4j2-impl:jar:2.22.0:compile
[WARNING] org.apache.spark:spark-core_2.12:jar:3.4.2:runtime
[WARNING] org.apache.spark:spark-sql_2.12:jar:3.4.2:runtime
[WARNING] org.apache.parquet:parquet-avro:jar:1.12.2:compile
[WARNING] org.apache.hadoop:hadoop-aws:jar:3.3.6:runtime
[WARNING] com.amazonaws:aws-java-sdk-bundle:jar:1.12.328:runtime
[WARNING] org.apache.hadoop:hadoop-azure:jar:3.3.6:runtime
[WARNING] com.google.cloud.bigdataoss:gcs-connector:jar:hadoop3-2.2.22:runtime
[WARNING] org.junit.jupiter:junit-jupiter-engine:jar:5.9.0:test
[WARNING] org.projectlombok:lombok:jar:1.18.30:provided


<!-- Hadoop dependencies -->
<dependency>
Expand All @@ -90,33 +88,6 @@
<scope>compile</scope>
</dependency>

<dependency>
<groupId>org.apache.parquet</groupId>
<artifactId>parquet-avro</artifactId>
</dependency>

<!-- AWS Dependencies -->
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-aws</artifactId>
</dependency>
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-bundle</artifactId>
</dependency>

<!-- Azure Dependencies -->
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-azure</artifactId>
</dependency>

<!-- GCS Dependencies -->
<dependency>
<groupId>com.google.cloud.bigdataoss</groupId>
<artifactId>gcs-connector</artifactId>
</dependency>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing these for the same reason as above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without these jars, user won't be able to run the xtable jar sync for s3 or gcs paths ?


<!-- Test Dependencies -->
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand All @@ -126,6 +97,7 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

Expand Down