Skip to content

Commit

Permalink
chore: remove tini binary (#1503)
Browse files Browse the repository at this point in the history
## Rationale
Our repo should not contain any binaries.

## Detailed Changes
- Download tini instead of hard copy

## Test Plan
CI

Also I use command below to ensure no other binaries exists.
```
fd -t file --exclude target --exec file {} \; | grep -v ASCII | grep -v UTF-8
```
  • Loading branch information
jiacai2050 authored and chunshao90 committed Mar 19, 2024
1 parent 03fa16a commit 1c56d2b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ integration_tests/dist_query/output
.tools
bin
coverage.txt
tini
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ RUN chmod +x /usr/bin/horaedb-server
COPY ./docker/entrypoint.sh /entrypoint.sh
COPY ./docs/minimal.toml /etc/horaedb/horaedb.toml

COPY ./docker/tini /tini
ARG TINI_VERSION=v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini

ARG USER=horae
Expand Down
Binary file removed docker/tini
Binary file not shown.
3 changes: 2 additions & 1 deletion horaemeta/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ RUN chmod +x /usr/bin/horaemeta-server
COPY ./docker/entrypoint.sh /entrypoint.sh
COPY ./config/example-standalone.toml /etc/horaemeta/horaemeta.toml

COPY ./docker/tini /tini
ARG TINI_VERSION=v0.19.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini

ARG USER horae
Expand Down
Binary file removed horaemeta/docker/tini
Binary file not shown.

0 comments on commit 1c56d2b

Please sign in to comment.