ensure response context does not mangle non-ascii characters #2396
Conversation
| @@ -95,11 +97,13 @@ public QueryResource( | |||
| { | |||
| this.config = config; | |||
| this.jsonMapper = jsonMapper; | |||
| this.asciiSafeJsonMapper = jsonMapper.copy().configure(JsonGenerator.Feature.ESCAPE_NON_ASCII, true); | |||
There was a problem hiding this comment.
There have been a number of fixes for copy() since the 2.4 branch. Notably FasterXML/jackson-databind#696
There was a problem hiding this comment.
Should be fine since it is just serializing a map
|
|
👍 assuming it is at least manually tested and found working. |
|
@xvrl did you run any tests against this? |
|
@xvrl ? |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
fixes #2372