Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicit java setup #442

Merged
merged 1 commit into from
Oct 15, 2024
Merged

explicit java setup #442

merged 1 commit into from
Oct 15, 2024

Conversation

AlexanderSaydakov
Copy link
Contributor

No description provided.

jmalkin
jmalkin approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jmalkin jmalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're definitely going to forget to update this when we move the java repo to 17...

@AlexanderSaydakov
Copy link
Contributor Author

This is to fix the failing serde compatibility action, that seems to have moved to Java 17 by default (Ubuntu 24.04 LTS)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11355111550

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.725%
Totals Coverage Status
Change from base Build 11354850793: 0.0%
Covered Lines: 16881
Relevant Lines: 17099
💛 - Coveralls

@AlexanderSaydakov AlexanderSaydakov merged commit f0e4e02 into master Oct 15, 2024
8 checks passed
@AlexanderSaydakov AlexanderSaydakov deleted the setup-java-action branch October 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmalkin jmalkin jmalkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSaydakov @coveralls @jmalkin