Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for python, especially nanobind #408

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

jmalkin
Copy link
Contributor

@jmalkin jmalkin commented Dec 3, 2023

Two changes here:

  • In KLL, check that src and dst are not equal before calling std::move in a few more places
  • In EBPPS, the bincond confused the compiler for certain complex types

Neither change should impact the API and they should both improve compatibility more generally, not just for our python repo.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7074002828

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.938%

Totals Coverage Status
Change from base Build 7025984769: 0.0%
Covered Lines: 16021
Relevant Lines: 16193

💛 - Coveralls

@jmalkin jmalkin merged commit 38657c3 into apache:master Dec 4, 2023
4 checks passed
@jmalkin jmalkin deleted the ebpps_serialize_fix branch December 4, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants