Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSGO-24 Remove global logger #1765

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

CASSGO-24 Remove global logger #1765

wants to merge 1 commit into from

Conversation

tengu-alt
Copy link
Contributor

@tengu-alt tengu-alt commented Jun 6, 2024 •
edited
Loading

This PR removes the global instance of the logger. For now, if the logger in the cluster config is not set, the new approach will set a new instance of the default logger for each session.
Issue: #1766

@joao-r-reis joao-r-reis changed the title global logger was removed CASSGO-24 global logger was removed Oct 30, 2024
@joao-r-reis
Copy link
Contributor

Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the CHANGELOG.md in the Changed section of Unreleased, thanks!

We need another committer +1 to merge this.

@tengu-alt tengu-alt force-pushed the logger-refactor branch 4 times, most recently from ccd50b0 to 9aa5d34 Compare November 13, 2024 10:13
@tengu-alt
Copy link
Contributor Author

Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the CHANGELOG.md in the Changed section of Unreleased, thanks!

We need another committer +1 to merge this.

Done.

@tengu-alt tengu-alt force-pushed the logger-refactor branch 2 times, most recently from 2a6781c to c8cfbeb Compare November 13, 2024 12:49
@martin-sucha
Copy link
Contributor

Just a nit pick, the commit title is in past tense now (Global logger was removed), as mentioned in CONTRIBUTING.md, it should be in the present tense instead (Remove global logger).

@tengu-alt
Copy link
Contributor Author

Just a nit pick, the commit title is in past tense now (Global logger was removed), as mentioned in CONTRIBUTING.md, it should be in the present tense instead (Remove global logger).

Good catch, I'll change it.

@tengu-alt tengu-alt changed the title CASSGO-24 global logger was removed CASSGO-24 emove Nov 18, 2024
@tengu-alt tengu-alt changed the title CASSGO-24 emove CASSGO-24 Remove global logger Nov 18, 2024
@tengu-alt tengu-alt force-pushed the logger-refactor branch 4 times, most recently from 6f71a2b to 493c135 Compare November 20, 2024 11:34
@tengu-alt
Remove global logger
3bd1594 
By default, if the logger in the cluster config is not set,
the NewSession() method sets a default logger instance
which is a deprecated global variable.

patch by Oleksandr Luzhniy; reviewed by João Reis, Stanislav Bychkov, for CASSGO-24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribaraka ribaraka ribaraka approved these changes

@joao-r-reis joao-r-reis joao-r-reis approved these changes

Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tengu-alt @joao-r-reis @martin-sucha @ribaraka