Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44805: [Dev] Add .editorconfig file #44870

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Nov 27, 2024

Add EditorConfig files for automatic text editor configuration. Only the most basic properties such as indent width are set.

Also remove .dir-locals.el files.

Copy link

⚠️ GitHub issue #44805 has been automatically assigned in GitHub to PR creator.

matlab/.editorconfig Outdated Show resolved Hide resolved
matlab/.editorconfig Outdated Show resolved Hide resolved
matlab/.editorconfig Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Nov 27, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Nov 28, 2024
Add EditorConfig files for automatic text editor configuration.
Only the most basic properties such as indent width are set.

Also remove `.dir-locals.el` files.
@pitrou
Copy link
Member Author

pitrou commented Nov 28, 2024

@kou @kevingurney I believe I have addressed your comments, can you take a look again?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou merged commit 1838d0a into apache:main Dec 2, 2024
12 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Dec 2, 2024
@pitrou pitrou deleted the gh44805-editorconfig branch December 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants