Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GH-43057: [C++] Debug sporadic CI crash #43936

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 3, 2024

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link

github-actions bot commented Sep 3, 2024

⚠️ GitHub issue #43057 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Failed to render template `docker-tests/github.linux.yml` with UndefinedError: 'failure' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/10684705446

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

@github-actions crossbow submit test-ubuntu-20.04-cpp

Copy link

github-actions bot commented Sep 3, 2024

Revision: cba1277

Submitted crossbow builds: ursacomputing/crossbow @ actions-494e659fc6

Task Status
test-ubuntu-20.04-cpp GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Sep 3, 2024

Ok, now that I finally managed to enable core dumps, I cannot get a crashing test anymore... Hopefully this will fail again later.

@pitrou
Copy link
Member Author

pitrou commented Sep 9, 2024

I'm going to close this PR now that we have stack traces

@pitrou pitrou closed this Sep 9, 2024
@pitrou pitrou deleted the gh43057-debug branch September 9, 2024 13:31
kou added a commit that referenced this pull request Sep 11, 2024
…bs (#43937)

### Rationale for this change

In #43936 I noticed that core dumps were not written out for crashing C++ tests. One problem is that, by default, Ubuntu hosts pipe core dumps to `apport`, but it is not available inside containers. Another is that the `ulimit` must be set in the host, not in the container.

In addition, this PR restores automatic traceback generation when running C++ tests, on Linux and macOS jobs.

### Are these changes tested?

Manually by introducing a spurious segfault and running Docker containers.

### Are there any user-facing changes?

No.

Lead-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…bs (apache#43937)

### Rationale for this change

In apache#43936 I noticed that core dumps were not written out for crashing C++ tests. One problem is that, by default, Ubuntu hosts pipe core dumps to `apport`, but it is not available inside containers. Another is that the `ulimit` must be set in the host, not in the container.

In addition, this PR restores automatic traceback generation when running C++ tests, on Linux and macOS jobs.

### Are these changes tested?

Manually by introducing a spurious segfault and running Docker containers.

### Are there any user-facing changes?

No.

Lead-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant