chore(ci): Add integration test CI docker image with all the arrows #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
changed the title
assignUser
approved these changes
Jul 17, 2024
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
eitsupi
reviewed
Jul 17, 2024
| @@ -94,15 +99,15 @@ jobs: | |||
| NANOARROW_PLATFORM: ${{ matrix.config.platform }} | |||
| DOCKER_DEFAULT_PLATFORM: "linux/${{ matrix.config.arch }}" | |||
| run: | | |||
| docker-compose push verify | |||
| docker-compose push ${{ matrix.config.service }} | |||
There was a problem hiding this comment.
Ah true, docker-compose is deprecated
There was a problem hiding this comment.
I think I need it because of the ARM runners here (the last time I checked, docker compose did not work there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test run for every commit by caching a recent docker image build (weekly) containing the built versions of integration tests from the Arrow monorepo and arrow-rs. This should result in a CI job with a reasonable run time that provides high-level testing and type coverage.
This is based on the arrow-rs version of the integration test job ( https://github.com/apache/arrow-rs/blob/6d4e2f2ceaf423031b0bc72f54c547dd77a0ddbb/.github/workflows/integration.yml ).