feat: Add support for custom ports #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedare
changed the title
|
Any update on this ? Can we help more ? Looks like I am missing some access to be able to solve the conflicts |
|
@ikatlinsky Please, can you have a look ? |
|
Please, @AlinsRan @Gallardot, when you have time could you review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add supports for custom ports without impacting the apisix configuration by itself.
It is useful to expose ports that may be exposed from specific apisix configuration like Prometheus.
This makes possible to monitor APISIX with Prometheus using only standard Kubernetes annotations and without requiring ServiceMonitor CRD support (it can also likely solve others usercases)
Fixed #720