Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nueva carga de mapas en formato .CSM #641

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Nueva carga de mapas en formato .CSM #641

wants to merge 20 commits into from

Conversation

joaquinodz
Copy link
Collaborator

@joaquinodz joaquinodz commented Apr 25, 2020 •
edited
Loading

Ventajas:

  • Mucho mas rapido.
  • TODA la informacion en 1 archivo. [.map, .inf, .dat -> .csm]
  • Como tenemos toda la info en el archivo, ahora si el mapa es de tipo DUNGEON no se renderiza la lluvia. Por lo que sacamos la carga del FK.ind

NOTA: Se separó todo el procedimiento de la lectura del archivo .csm en un Sub aparte en el módulo Carga para tener un mejor control de lo que pasa antes y después de la carga del mapa.

Fixes #35

@joaquinodz
Copy link
Collaborator Author

Call Load_Map_Particles(Map) debe ser puesto de nuevo.

No hace falta, es una villereada que hice xq me daba paja usar el WE.

@joaquinodz
Copy link
Collaborator Author

Borrar este archivo que no se necesita.

Listo!

@RecoX RecoX changed the title Nueva carga de mapas en formato .CSM WIP - Nueva carga de mapas en formato .CSM Apr 25, 2020
@RecoX
Copy link
Member

RecoX commented Apr 25, 2020

Nota: No mergear hasta que esten los PRs de:

ao-server
ao-worldeditor

y se haya testeado a fondo tanto con:

Creando un nuevo mundo y hacerlo jugable
Convertir map en csm y que funcione correctamente.
Triggers, Luces, Particulas, etc.

@joaquinodz joaquinodz changed the title WIP - Nueva carga de mapas en formato .CSM Nueva carga de mapas en formato .CSM Jul 8, 2020
RecoX
RecoX reviewed Jul 8, 2020
View reviewed changes
CODIGO/Areas/mPooMap.bas Outdated Show resolved Hide resolved
CODIGO/General.bas Show resolved Hide resolved
CODIGO/IO/modCarga.bas Show resolved Hide resolved
CODIGO/Red/Protocol.bas Show resolved Hide resolved
@RecoX
Copy link
Member

RecoX commented Jul 8, 2020

Eliminar fk.ind y fk.txt

@joaquinodz
Copy link
Collaborator Author

Partículas funcionales! @ReyarB

@cucsijuan
Copy link
Contributor

Que onda esto? esta para mergear? se hizo PR en el editor de mapas? se probo que todas las features de lso mapas funcionen? @jopiortiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RecoX RecoX RecoX left review comments

@RedrootDEV RedrootDEV Awaiting requested review from RedrootDEV

@alejolp alejolp Awaiting requested review from alejolp alejolp is a code owner

@brunodeangelis brunodeangelis Awaiting requested review from brunodeangelis brunodeangelis is a code owner

@cucsijuan cucsijuan Awaiting requested review from cucsijuan cucsijuan is a code owner

@FrankoH298 FrankoH298 Awaiting requested review from FrankoH298 FrankoH298 is a code owner

@guidota guidota Awaiting requested review from guidota

@jsotuyod jsotuyod Awaiting requested review from jsotuyod jsotuyod is a code owner

@juandpr juandpr Awaiting requested review from juandpr

@Lorwik Lorwik Awaiting requested review from Lorwik Lorwik is a code owner

@neoranger neoranger Awaiting requested review from neoranger neoranger is a code owner

@patotorres patotorres Awaiting requested review from patotorres patotorres is a code owner

@ReyarB ReyarB Awaiting requested review from ReyarB ReyarB is a code owner

@Wyr0X Wyr0X Awaiting requested review from Wyr0X Wyr0X is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FK.ind - colocar info en los mapas
4 participants
@joaquinodz @RecoX @cucsijuan @FrankoH298