Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve bug that prevents two equally seeded reference direction calculations (energy reduction method) to produce the same output #556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pymoo/algorithms/moo/nsga3.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,11 @@ def get_extreme_points_c(F, ideal_point, extreme_points=None):
__F = _F - ideal_point
__F[__F < 1e-3] = 0

# normalize __F
__F_norm = (__F - np.min(__F, axis=0)) / (np.max(__F, axis=0) - np.min(__F, axis=0))

# update the extreme points for the normalization having the highest asf value each
F_asf = np.max(__F * weights[:, None, :], axis=2)
F_asf = np.max(__F_norm * weights[:, None, :], axis=2)

I = np.argmin(F_asf, axis=1)
extreme_points = _F[I, :]
Expand Down
3 changes: 2 additions & 1 deletion pymoo/util/ref_dirs/energy.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ def _do(self):
X = ReductionBasedReferenceDirectionFactory(self.n_dim,
self.n_points,
kmeans=True,
lexsort=False) \
lexsort=False,
seed=self.seed) \
.do()

elif self.sampling == "construction":
Expand Down
3 changes: 2 additions & 1 deletion pymoo/util/ref_dirs/reduction.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ def __init__(self,
self.n_points = n_points

def _do(self):
rnd = sample_on_unit_simplex(self.n_sample_points, self.n_dim, unit_simplex_mapping=self.sampling)
rnd = sample_on_unit_simplex(self.n_sample_points, self.n_dim, unit_simplex_mapping=self.sampling,
seed=self.seed)

def h(n):
return get_partition_closest_to_points(n, self.n_dim)
Expand Down