Fix docs about SecondaryNetwork feature #6837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
the
kind/cleanup
Include SecondaryNetwork related configurations in the YAMLs to simplify usage with installation methods other than Helm, which also aligns with other features' configurations. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
force-pushed
the
secondary-network-doc
branch
from
cc4c161
to
4a371a0
Compare
jianjuns
reviewed
Nov 28, 2024
| # interfaces using SR-IOV VFs on baremetal Nodes. | ||
| # Pod annotations). At the moment, Antrea can create secondary network | ||
| # interfaces either using SR-IOV VFs on bare-metal Nodes or veth interfaces | ||
| # bridged to the underlay network, with or without VLAN tagging. |
There was a problem hiding this comment.
What does this sentence "veth interfaces bridged to the underlay network, with or without VLAN tagging" mean?
There was a problem hiding this comment.
I checked the implementation of VLAN type and think the secondary network is a veth device connected to an OVS bridge with a pNIC attached, so isn't it essentially "Antrea can create secondary network interfaces using veth interfaces bridged to the underlay network"? "with or without VLAN tagging" means traffic from secondary network interfaces can support both VLAN tagging and non VLAN tagging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include SecondaryNetwork related configurations in the YAMLs to simplify usage with installation methods other than Helm, which also aligns with other features' configurations.