Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference #883: env timeout open k8s logstream #1154

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

aeter
Copy link

@aeter aeter commented Oct 3, 2024

References #883

Adds env variable to configure open logstream timeout.

Please note: when writing this PR: not sure where/how to document the env variable (other than in the code), so users can find it.

Testing:

$ PATH="${PWD}:${PATH}" go test ./pkg/workceptor/kubernetes_test.go
ok      command-line-arguments  0.014s
$ PATH="${PWD}:${PATH}" go test ./pkg/workceptor/kubernetes_test.go -count=1 -race -timeout 5m
ok      command-line-arguments  1.053s 

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.46%. Comparing base (1be2c55) to head (bb0b10f).
Report is 41 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/kubernetes.go 91.66% 1 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1154      +/-   ##
==========================================
+ Coverage   43.26%   43.46%   +0.19%     
==========================================
  Files          33       33              
  Lines        6691     6702      +11     
==========================================
+ Hits         2895     2913      +18     
+ Misses       3552     3546       -6     
+ Partials      244      243       -1     
Files with missing lines Coverage Δ
pkg/workceptor/kubernetes.go 21.72% <91.66%> (+0.88%) ⬆️

... and 3 files with indirect coverage changes

Components Coverage Δ
Go 43.46% <91.66%> (+0.19%) ⬆️
Receptorctl ∅ <ø> (∅)

🚨 Try these New Features:

@JoelKle
Copy link

JoelKle commented Nov 18, 2024

thank you for the PR, @aeter! @AaronH88, @thom-at-redhat, @fosterseth - besides the small linting issues to fix, do we need anything else for this PR?

Signed-off-by: Adrian Nackov <adrian.nackov@mail.schwarz>
@aeter aeter force-pushed the 883-fix-insufficient-timeout-opening-k8s-stream branch from bb0b10f to 89a2cf7 Compare November 21, 2024 08:03
Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants