-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sigstore signing and verification (v2) #46
Open
mayaCostantini
wants to merge
15
commits into
ansible:main
Choose a base branch
from
mayaCostantini:sigstorev2-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7cb1100
Add support for Sigstore signing and verification (v2)
mayaCostantini e906bdb
Remove Sigstore signer subclass
mayaCostantini 12fba3e
Add sigstore test fixtures
mayaCostantini eba0a15
Adapt test_cli to sigstore v2
mayaCostantini 9062d65
Fix verification materials unpacking
mayaCostantini 65c8aaa
Add __all__ in signing submodule
mayaCostantini 1ee46cf
Remove arguments from _collect_verification_state() for sigstore sign…
mayaCostantini 7c7b104
Update sigstore-python version to stable v2.0.0
mayaCostantini 860a4f8
Backport fix from sigstore-python CLI https://github.com/sigstore/sig…
mayaCostantini 38c7525
Update public keys fetching logic
mayaCostantini 1e33cfa
Remove sigstore bundles from .gitignore for tests
mayaCostantini f4206e7
Update documentation for sigstore signing with project subcommand
mayaCostantini 6e5631c
Do not ignore .ansible-sign files as test fixtures
mayaCostantini bc46f52
Bump sigstore dependency to 2.1.2
mayaCostantini e575be6
Fix sigstore-related tests
mayaCostantini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,3 +52,7 @@ MANIFEST | |
.venv*/ | ||
.conda*/ | ||
.python-version | ||
|
||
# ansible-sign files and directories | ||
/.ansible-sign/* | ||
/MANIFEST.in |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? It looks like
--oidc-issuer
has been renamed to--cert-oidc-issuer
but it still looks like it's marked required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--cert-oidc-issuer
is the option passed to verify signatures and--oidc-issuer
the one to specify a private OIDC issuer instance for signing