Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable http server at the end of eos_eapi tests #217

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Enable http server at the end of eos_eapi tests #217

wants to merge 8 commits into from

Conversation

GomathiselviS
Copy link
Contributor

Signed-off-by: GomathiselviS gomathiselvi@gmail.com

SUMMARY

HTTP server is disabled as part of eos_eapi test configure.yaml. This PR enables the server at the end of the test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@GomathiselviS
Enable http server at the end of eos_eapi tests
77f18de 
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
@GomathiselviS GomathiselviS mentioned this pull request May 26, 2021
Closed
@GomathiselviS GomathiselviS reopened this May 26, 2021
Qalthos
Qalthos reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good. I'll leave it up to you whether you take my comment or merge as-is

tests/integration/targets/eos_eapi/tests/cli/configure.yaml Outdated Show resolved Hide resolved
@GomathiselviS
Copy link
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

@rohitthakur2590 rohitthakur2590 Awaiting requested review from rohitthakur2590

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GomathiselviS @Qalthos