-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'width', 'show-alpha', 'disable-input-field' prop and some default-colors style fix. #100
Open
Akash187
wants to merge
9
commits into
anish2690:master
Choose a base branch
from
Akash187:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/anishgeorge2690/vue-color-kit/HbpSr6pquULbFnnpcuRa4VWtmBXq |
Akash187
changed the title
Added option to pass width as a 'width' prop and some default-colors style fix.
Added 'width' and 'show-alpha' prop and some default-colors style fix.
Nov 5, 2021
Akash187
changed the title
Added 'width' and 'show-alpha' prop and some default-colors style fix.
Added 'width', 'show-alpha', 'disable-input-field' prop and some default-colors style fix.
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
width
prop to pass width show that user can change the width of color picker current 198px width seems to be a bit small.show-alpha
prop to show and hidealpha
panel andrgba
box.disable-input-field
prop to disable user from manually enter color value. This is helpful because sometimes you don't want users to enter invalid colors. Disabling input can prevent such cases.Other information:
I was not able to run tests using
yarn test
getting an error. Image attached.