Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'width', 'show-alpha', 'disable-input-field' prop and some default-colors style fix. #100

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Akash187
Copy link

@Akash187 Akash187 commented Nov 5, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • Added width prop to pass width show that user can change the width of color picker current 198px width seems to be a bit small.
  • Added show-alpha prop to show and hide alpha panel and rgba box.
  • Added disable-input-field prop to disable user from manually enter color value. This is helpful because sometimes you don't want users to enter invalid colors. Disabling input can prevent such cases.
  • Fixed default-colors style.
  • Made style scoped so they don't interfere with project style.

Other information:
I was not able to run tests using yarn test getting an error. Image attached.
Screenshot 2021-11-05 at 5 34 08 PM

@vercel
Copy link

vercel bot commented Nov 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anishgeorge2690/vue-color-kit/HbpSr6pquULbFnnpcuRa4VWtmBXq
✅ Preview: https://vue-color-kit-git-fork-akash187-master-anishgeorge2690.vercel.app

@Akash187 Akash187 changed the title Added option to pass width as a 'width' prop and some default-colors style fix. Added 'width' and 'show-alpha' prop and some default-colors style fix. Nov 5, 2021
@Akash187 Akash187 mentioned this pull request Nov 5, 2021
12 tasks
@Akash187 Akash187 changed the title Added 'width' and 'show-alpha' prop and some default-colors style fix. Added 'width', 'show-alpha', 'disable-input-field' prop and some default-colors style fix. Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant