Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal handling improvements #329

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Signal handling improvements #329

wants to merge 5 commits into from

Commits on Apr 16, 2022

  1. Signal handling: Factor out common signal handling code

    @rhansen
    rhansen committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    d7edfe9 View commit details
    Browse the repository at this point in the history

  2. Signal handling: Always exit non-zero 

    The default signal handler always exits non-zero so the signal
listener installed by threads.js should too.
    @rhansen
    rhansen committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    f8c6087 View commit details
    Browse the repository at this point in the history

  3. Signal handling: Allow worker.terminate() to be synchronous 

    This also suppresses any synchronous exceptions thrown by
`worker.terminate()`.
    @rhansen
    rhansen committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    7877248 View commit details
    Browse the repository at this point in the history

  4. Signal handling: Wait for all workers to terminate 

    The promise returned from `Promise.all()` immediately rejects if any
of the underlying promises reject, even if some of the other promises
have not yet settled. Catch each rejection to give the other promises
an opportunity to resolve.

`Promise.allSettled()` could be used instead, but that's a relatively
new function that was added in Node.js v12.9.0.
    @rhansen
    rhansen committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    58d04b3 View commit details
    Browse the repository at this point in the history

  5. Signal handling: Don't exit if there are other signal listeners

    @rhansen
    rhansen committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    6c561d4 View commit details
    Browse the repository at this point in the history