Make comment Author & UpdateAuthor properties pointers #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LaurenceTews thanks for the fix! @andygrunwald Kind reminder, could you please review this? |
This was referenced Aug 1, 2023
|
Keen to have this merged, using a workaround for now |
|
I can confirm this works - I've been fighting this problem today and was just about to put in an identical PR. Would be really nice to get merged :) |
|
@andygrunwald – can you take a look at this PR? We have a confirmations above that this PR fixes the bug, including folks using my downstream project, which is currently importing a fork of this repo which carries the patch: |
anwalsh
added a commit
to anwalsh/go-jira
that referenced
this pull request
Jul 23, 2024
mt40
added a commit
to mt40/go-jira
that referenced
this pull request
Aug 15, 2024
mt40
added a commit
to mt40/go-jira
that referenced
this pull request
Aug 15, 2024
|
This would really be nice to have merged - it must be failing for a lot of people...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently requests built using the AddComment() and UpdateComment() functions will fail (HTTP 400) due to a schema mismatch. Because Author and UpdateAuthor properties are not pointers, they get marshalled into the resulting JSON body, rather than being omitted via omitempty.
This change brings the Comment struct type in line with other structs that using pointers for Author and UpdateAuthor properties.
Which issue(s) this PR fixes:
#604
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: