Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more account operations #150

Merged
merged 4 commits into from
Aug 20, 2023
Merged

Conversation

hanwen
Copy link
Contributor

@hanwen hanwen commented Aug 17, 2023

No description provided.

Add the type AccountExternalIdInfo to serve as return value. The
naming (Id rather than ID) is picked to be consistent with the Gerrit
documentation.
@hanwen
Copy link
Contributor Author

hanwen commented Aug 17, 2023

thanks for go-gerrit: it's polished and well-documented. The Gerrit team says thank you!

@andygrunwald
Copy link
Owner

@hanwen What a surprise. Thanks :) (also for the PR).

The first quick review looks good. I am a little short on time this weekend, but I will review this in detail this weekend or at the beginning of the week.

@andygrunwald andygrunwald merged commit bed9700 into andygrunwald:master Aug 20, 2023
8 checks passed
@andygrunwald
Copy link
Owner

Thanks a lot again. Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants