Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BLE): Adding Bluetooth example for MAX32657 #1246

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

kevin-gillespie
Copy link
Contributor

@kevin-gillespie kevin-gillespie commented Nov 1, 2024

Description

Adding Bluetooth example for MAX32657. Adding options for libphy.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.

@github-actions github-actions bot added the BLE Related to Bluetooth label Nov 1, 2024
@crsz20
Copy link
Contributor

crsz20 commented Nov 4, 2024

The changes look good. Though I am unable to build the project:

msdk/Libraries/Packetcraft-ADI/platform/targets/maxim/build/cordio_lib.mk: No such file or directory
make: *** No rule to make target '/msdk/Libraries/Packetcraft-ADI/platform/targets/maxim/build/cordio_lib.mk'.  Stop.

Do I need to checkout a specific branch of Packetcraft-ADI?

@kevin-gillespie
Copy link
Contributor Author

Do I need to checkout a specific branch of Packetcraft-ADI?

Yes, you'll have to checkout the feat/max32657 branch. We will have a few unmet dependencies until we get all of the different repos aligned.

@crsz20
Copy link
Contributor

crsz20 commented Nov 4, 2024

We will have a few unmet dependencies until we get all of the different repos aligned.

Ah, that may explain the following output:

MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: msdk/Libraries/Packetcraft-ADI/controller/libs/libcontroller_maxim_cortex-m33_softfp_trace.a(lhci_cmd_vs.o): in function `lhciCommonVsStdDecodeCmdPkt':

msdk/Libraries/packetcraft-adi/controller/sources/ble/lhci/lhci_cmd_vs.c:327: undefined reference to `PalBbFgenIsEnabled'

MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: msdk/Libraries/packetcraft-adi/controller/sources/ble/lhci/lhci_cmd_vs.c:333: undefined reference to `PalBbEnableFgen'

MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: msdk/Libraries/packetcraft-adi/controller/sources/ble/lhci/lhci_cmd_vs.c:339: undefined reference to `PalBbDisableFgen'

MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: msdk/Libraries/packetcraft-adi/controller/sources/ble/lhci/lhci_cmd_vs.c:394: undefined reference to `WsfCsStatsGetCsWaterMark'

@kevin-gillespie kevin-gillespie merged commit e0967e1 into main Nov 6, 2024
13 of 14 checks passed
@kevin-gillespie kevin-gillespie deleted the feat/max32657-ble branch November 6, 2024 23:01
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Related to Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants