Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Update permissions for pm2, laravel app-release commands #7

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

greyvugrin
Copy link
Contributor

Updated pm2 & laravel release commands.

Fixed an issue where custom log paths like DockerLocal/logs would not have the OWNER_USER:OWNER_GROUP applied at all folder levels.

Caused issues:

  • deploy.sh wasn't able to delete old releases
  • logrotate on log files would fail bc www-data wasn't able to delete old logs

@@ -196,10 +196,22 @@ sudo chmod 777 "$CURRENT/storage" -R
sudo chmod 777 "$CURRENT/bootstrap" -R

## Make Logs Directory
sudo mkdir -p "$REPO_ROOT/$LARAVELLOGSFOLDER_LOCATION"
sudo mkdir -m 775 -p "$REPO_ROOT/$LARAVELLOGSFOLDER_LOCATION"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make the end directory have the correct permissions, but not the full tree. hence the looping afterward

Copy link
Owner

@amurrell amurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about wordpress-deploy?

@amurrell
Copy link
Owner

amurrell commented Aug 1, 2024

Reminder: You mentioned that you may still have log permission issues and this may not solve it?

@amurrell amurrell changed the title Update permissions for pm2, laravel app-release commands WIP - Update permissions for pm2, laravel app-release commands Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants