test: serialiser #48

ambiorix-web · Mar 26, 2022 · 7f15a1c · 7f15a1c
1 parent 82b5cf5
commit 7f15a1c
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/R/ambiorix.R b/R/ambiorix.R
@@ -208,6 +208,7 @@ Ambiorix <- R6::R6Class(
 #' if(interactive())
 #'  app$start()
     serialiser = function(handler){
+      assert_that(is_function(handler))
       options(AMBIORIX_SERIALISER = handler)
       invisible(self)
     },
@@ -238,12 +239,6 @@ Ambiorix <- R6::R6Class(
     }
   ),
   active = list(
-    websocket = function(value){
-      if(missing(value))
-        stop("This is a setter only")
-
-      private$.wss <- value
-    },
     port = function(value) {
       if(missing(value))
         return(private$.port)

diff --git a/makefile b/makefile
@@ -6,3 +6,6 @@ check: document
 
 document: 
 	Rscript -e "devtools::document()"
+
+test:
+	Rscript -e "devtools::test()"
diff --git a/man/Ambiorix.Rd b/man/Ambiorix.Rd
diff --git a/tests/testthat/test-basic.R b/tests/testthat/test-basic.R
@@ -26,4 +26,10 @@ test_that("Ambiorix", {
   expect_s3_class(app$set_404(\(req, res) {
     res$send("Errr")
   }), "Ambiorix")
+
+  expect_error(app$serialiser("error"))
+  expect_s3_class(app$serialiser(\(data) {
+    return("data")
+  }), "Ambiorix")
+
 })