Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ppline in Alignment class #59

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

arajkovic
Copy link
Contributor

Hi!

This PR exposes the ppline string from P7_ALIDISPLAY.
We're using pyhmmer here at EBI for the new version of the HMMER web tool. While working on the alignment display, I realised that the posterior probability annotation (ppline) is missing, so adding it to the Alignment class.

Cheers!

@althonos
Copy link
Owner

Would you mind naming it posterior_probabilities instead of ppline, to be a bit more informative on the Python side? Thanks for the PR 😄

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (149785c) 79.59% compared to head (ec8d6d8) 79.60%.
Report is 1 commits behind head on master.

❗ Current head ec8d6d8 differs from pull request most recent head a3f33a1. Consider uploading reports for the commit a3f33a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   79.59%   79.60%           
=======================================
  Files           7        7           
  Lines        7008     7010    +2     
=======================================
+ Hits         5578     5580    +2     
  Misses       1430     1430           
Flag Coverage Δ
v3.10 79.60% <100.00%> (+<0.01%) ⬆️
v3.11 79.60% <100.00%> (+<0.01%) ⬆️
v3.12 79.60% <100.00%> (+<0.01%) ⬆️
v3.7 79.57% <100.00%> (+<0.01%) ⬆️
v3.8 79.60% <100.00%> (+<0.01%) ⬆️
v3.9 79.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@althonos althonos merged commit 6a6301a into althonos:master Feb 16, 2024
@althonos
Copy link
Owner

Thanks! I'll make a new release shortly.

@althonos althonos added the enhancement New feature or request label Feb 16, 2024
@arajkovic arajkovic deleted the alignment-ppline branch February 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants