Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: alicloud_arms_alert_robots and New Resource: alicloud_arms_alert_robot #7898

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

icloudnote
Copy link
Contributor

add new resource arms_alert_robot
add new data source arms_alert_robots

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

@@ -433,6 +433,9 @@
<li>
<a href="/docs/providers/alicloud/d/arms_alert_contacts.html">alicloud_arms_alert_contacts</a>
</li>
<li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的资源,数据源接入已经不需要再alicloud.erb文件中声明

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我这边已经将 alicloud.erb 文件中的修改移除了.

@icloudnote icloudnote force-pushed the arms_alert_robot branch 2 times, most recently from 01deffc to 85e2197 Compare November 27, 2024 08:27

For information about Application Real-Time Monitoring Service (ARMS) Alert Robot and how to use it, see [What is Alert Robot](https://next.api.alibabacloud.com/document/ARMS/2019-08-08/CreateOrUpdateIMRobot).

-> **NOTE:** Available since v1.135.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下一版本号为 1.236.0


This data source provides the Arms Alert Robots of the current Alibaba Cloud user.

-> **NOTE:** Available since v1.135.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下一版本号为 1.236.0

Basic Usage

```terraform
data "alicloud_arms_alert_robots" "nameRegex" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要在前置创建出一个 robot,之后使用 Datasource 查询该实例

@ChenHanZhang
Copy link
Collaborator

CI 校验中的错误需要处理下哈

@icloudnote icloudnote changed the title New Resource: arms_alert_robot; New Data Source arms_alert_robots New Data Source: alicloud_arms_alert_robots Nov 28, 2024
@icloudnote icloudnote changed the title New Data Source: alicloud_arms_alert_robots New Data Source: alicloud_arms_alert_robots and New Resource: alicloud_arms_alert_robot Nov 28, 2024
@icloudnote icloudnote force-pushed the arms_alert_robot branch 2 times, most recently from b83f966 to d1ece2c Compare November 28, 2024 06:07
@icloudnote
Copy link
Contributor Author

我这边已经修复了一些, 你这边再帮忙走一下CI, 我这边再看看还有啥错误, 谢谢.

@icloudnote
Copy link
Contributor Author

再帮忙走一下CI, 看看是不是已经修复了.

@ChenHanZhang
Copy link
Collaborator

需要rebase下主干

@icloudnote
Copy link
Contributor Author

已经rebase到主干了.

@icloudnote icloudnote force-pushed the arms_alert_robot branch 4 times, most recently from ba5a34a to 37f98d9 Compare November 29, 2024 07:15

The following arguments are supported:

- `alert_robot_name` - (Required) The name of the resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要使用 * 号

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

robot_addr = "https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=1c704e23"
}
data "alicloud_arms_alert_robots" "nameRegex" {
name_regex = "^my-AlertRobot"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要使用引用的方式,否则datasource的执行会在resource之前,导致无法查到数据

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修复了.

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ChenHanZhang
Copy link
Collaborator

当前PR所有校验均已通过,但由于当前版本已经在走发布流程,该资源会在下周的版本合入并发布。再次感谢您对阿里云的支持!

@ChenHanZhang ChenHanZhang merged commit 7389e38 into aliyun:master Nov 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants