This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Improve loading experience (like, a lot!) #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nop33
commented
Aug 9, 2023
mvaivre
reviewed
Aug 14, 2023
package.json
Outdated
| @@ -33,10 +33,10 @@ | |||
| "electron-updater": "^5.3.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@alephium/sdk": "0.7.2", | |||
| "@alephium/token-list": "^0.0.8", | |||
| "@alephium/sdk": "0.7.3", | |||
| ...details, | ||
| tokens, | ||
| transactions: uniq([...address.transactions, ...transactionHashes]), | ||
| transactions: uniq(address.transactions.concat(transactions.map((tx) => tx.hash))), |
There was a problem hiding this comment.
Nit: we usually use spreading to do this, which is easier to read IMO.
uniq([...address.transactions, ...map(transactions, 'hash')])or
uniq([...address.transactions, ...transactions.map((tx) => tx.hash)])(because I'm sad about the typing of lodash's property shorthand map which isn't strict...)
|
Incredible jump in performances. This feels extremely good. |
mvaivre
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.