Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print SRE FQDN when deployment finishes #2297

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Nov 15, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Exports the sre_fqdn to the SRE stack, prints the FQDN at the end of the deployment process.

🌂 Related issues

Closes #2274

🔬 Tests

Tested locally

@craddm craddm changed the title Print sre fqdn Print SRE FQDN when deployment finishes Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  sre.py 167
  data_safe_haven/infrastructure/programs
  declarative_sre.py 423
Project Total  

This report was generated by python-coverage-comment-action

@craddm craddm changed the base branch from release-v5.1.0 to develop November 18, 2024 10:58
@craddm craddm marked this pull request as ready for review November 19, 2024 14:50
@craddm craddm requested a review from a team as a code owner November 19, 2024 14:50
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could we have an example of the output?

data_safe_haven/commands/sre.py Outdated Show resolved Hide resolved
@JimMadge JimMadge merged commit d1f9d98 into alan-turing-institute:develop Nov 20, 2024
11 checks passed
@JimMadge
Copy link
Member

Screenshot 2024-11-20 at 14 30 53

@craddm craddm deleted the print-sre-fqdn branch December 3, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show the Guacamole URL on the terminal after creating an SRE
2 participants