Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.2.2 #1955

Merged
merged 44 commits into from
Jul 15, 2024
Merged

Release v4.2.2 #1955

merged 44 commits into from
Jul 15, 2024

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Release candidate for v4.2.2

🌂 Related issues

Closes #1942

🔬 Tests

JimMadge
JimMadge previously approved these changes Jun 21, 2024
@jemrobinson jemrobinson marked this pull request as draft June 21, 2024 14:00
@jemrobinson
Copy link
Member Author

@JimMadge : I think @craddm is still testing this. I've converted it to a draft so we don't merge prematurely.

@JimMadge
Copy link
Member

JimMadge commented Jul 8, 2024

@craddm Is the code ready to go?

@craddm
Copy link
Contributor

craddm commented Jul 8, 2024

Code is ready, #1993 changes the documentation

@jemrobinson
Copy link
Member Author

Does this also suffer from the DockerHub issue? What's our suggested fix?

@craddm
Copy link
Contributor

craddm commented Jul 8, 2024

Yes, actually, it does, since multiple components rely on docker images running on VMs (e.g. web apps)

@jemrobinson
Copy link
Member Author

One possible fix for this is to add docker login -u $DOCKER_USER -p $DOCKER_PASSWORD lines each time we call docker pull with DOCKER_USER and DOCKER_PASSWORD coming from the config file.

Thoughts?

@jemrobinson jemrobinson changed the title Release v4.2.2 [WIP] Release v4.2.2 Jul 12, 2024
@JimMadge JimMadge marked this pull request as ready for review July 15, 2024 12:56
@JimMadge JimMadge self-requested a review July 15, 2024 12:56
@JimMadge
Copy link
Member

@craddm Are the release notes ready to go?

@JimMadge JimMadge changed the title [WIP] Release v4.2.2 Release v4.2.2 Jul 15, 2024
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of Markdown suggestions.

docs/source/deployment/deploy_shm.md Outdated Show resolved Hide resolved
docs/source/deployment/deploy_shm.md Outdated Show resolved Hide resolved
craddm and others added 2 commits July 15, 2024 14:03
Co-authored-by: Jim Madge <jmadge@turing.ac.uk>
Co-authored-by: Jim Madge <jmadge@turing.ac.uk>
@craddm
Copy link
Contributor

craddm commented Jul 15, 2024

@craddm Are the release notes ready to go?

Yes, think this is it. The VPN change only applies to new deployments so existing ones should continue to work without needing to update anything

JimMadge
JimMadge previously approved these changes Jul 15, 2024
craddm
craddm previously approved these changes Jul 15, 2024
@craddm craddm dismissed stale reviews from JimMadge and themself via ea58b64 July 15, 2024 14:28
JimMadge
JimMadge previously approved these changes Jul 15, 2024
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update the expected output in tests.

@craddm craddm merged commit 008d346 into latest Jul 15, 2024
11 checks passed
@craddm craddm deleted the release-v4.2.2 branch July 15, 2024 14:51
@jemrobinson jemrobinson mentioned this pull request Jul 15, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants