show half hour marks on the left-hand column #193
Conversation
| @@ -7,5 +7,5 @@ | |||
| */ | |||
| public interface DateTimeInterpreter { | |||
| String interpretDate(Calendar date); | |||
| String interpretTime(int hour); | |||
| String interpretTime(int hour, int minutes); | |||
There was a problem hiding this comment.
Should I create a new method with interpretTime(int hour, minutes) and leave the original interpretTime(int hour) to not break people?
There was a problem hiding this comment.
Hold on, that doesn't actually help. Just by adding the interpretTime(int hour, int minutes) to the interface will break an client implementing that interface. Only if we had a base class and people extended that, could we then add a method to the interface and not break consumer.
There was a problem hiding this comment.
Maybe have a "subinterface"?
Because a breaking change for this small behaviour change is maybe not what we want.
|
Rebased changes |
|
Can this be merged? |
|
This is still a breaking change, no? Because I'm not sure if I want to break the library for something small like this. |
|
hi, would be great if this pr can be merged i think this extension of the interface is a very small breaking change and can be easily fixed by anyone. |
|
Fine for me. @alamkanak Is it ok for you as well? @dgrant Can you rebase onto master again? |
dgrant
force-pushed
the
showHalfHours
branch
from
2c65d3e
to
528565c
Compare
|
@caske33 Ok, I've rebased it on master. |
|
Can you squash those commits? Also, there still seems to be a merge conflict. Maybe try rebasing on develop? Thank you for your patience! 💯 |
|
Ok, finally cleaned everything up. Sorry for the delay. |
|
👍 |
|
showHalfHours not working , Need Help |
dgrant
force-pushed
the
showHalfHours
branch
from
90c3663
to
67a8772
Compare
dgrant
force-pushed
the
showHalfHours
branch
from
67a8772
to
06836e7
Compare
|
how to use timespacing. ? showHalfHours changes the left column to show time with half hour intervals . rest all working same i.e on hour basis. Need urgent help |
Here is the "show half hours change", now rebased on develop branch.